nullref fixes

.gitignore

@@ -378,3 +378,4 @@ site/
 
 .aider.*
 PROMPT.md
+.aider*

src/EllieBot/Db/Extensions/DbExtensions.cs

@@ -10,12 +10,6 @@ public static class DbExtensions
         where T : DbEntity
         => set.FirstOrDefault(x => x.Id == id);
 
-    public static GuildConfig GuildConfigsForId(this DbContext ctx, ulong guildId)
-    {
-        var query = ctx.Set<GuildConfig>().Where(gc => gc.GuildId == guildId);
-        return query.FirstOrDefault();
-    }
-
     public static GuildFilterConfig FilterConfigForId(
         this DbContext ctx,
         ulong guildId,
@@ -24,14 +18,14 @@ public static class DbExtensions
         includes ??= static set => set;
 
         var gfc = includes(ctx.Set<GuildFilterConfig>()
-                         .Where(gc => gc.GuildId == guildId))
+                              .Where(gc => gc.GuildId == guildId))
             .FirstOrDefault();
 
         if (gfc is null)
         {
-            ctx.Add(gfc = new GuildFilterConfig()
+            ctx.Add(gfc = new()
             {
-                GuildId = guildId
+                GuildId = guildId,
             });
         }
 
@@ -46,15 +40,14 @@ public static class DbExtensions
         includes ??= static set => set;
 
         var gc = includes(ctx.Set<GuildConfig>()
-                    .Where(gc => gc.GuildId == guildId))
+                             .Where(gc => gc.GuildId == guildId))
             .FirstOrDefault();
 
         if (gc is null)
         {
-            ctx.Add(gc = new GuildConfig()
+            ctx.Add(gc = new()
             {
                 GuildId = guildId,
-                Permissions = []
             });
         }
 

src/EllieBot/Db/Models/GuildConfig.cs

@@ -65,5 +65,5 @@ public class GuildConfig : DbEntity
     public string TimeZoneId { get; set; }
     public string Locale { get; set; }
 
-    public List<Permissionv2> Permissions { get; set; }
+    public List<Permissionv2> Permissions { get; set; } = [];
 }