From 05c03248c4c480f07e10f7fc1949a29be76d57b5 Mon Sep 17 00:00:00 2001
From: Toastie <toastie@toastiet0ast.com>
Date: Sat, 17 Aug 2024 19:21:49 +1200
Subject: [PATCH] small cleanup of utility.cs

---
 src/EllieBot/Modules/Utility/Utility.cs | 62 +++++++++++--------------
 1 file changed, 27 insertions(+), 35 deletions(-)

diff --git a/src/EllieBot/Modules/Utility/Utility.cs b/src/EllieBot/Modules/Utility/Utility.cs
index dffad00..f84cd43 100644
--- a/src/EllieBot/Modules/Utility/Utility.cs
+++ b/src/EllieBot/Modules/Utility/Utility.cs
@@ -222,17 +222,7 @@ public partial class Utility : EllieModule
             builder.AppendLine($"{p.Name} : {p.GetValue(perms, null)}");
         await Response().Confirm(builder.ToString()).SendAsync();
     }
-
-    // [Cmd]
-    // [RequireContext(ContextType.Guild)]
-    // [RequireUserPermission(GuildPermission.ManageRoles)]
-    // public async Task CheckPerms(SocketRole role, string perm = null)
-    // {
-    //     ChannelPermissions.
-    //     var perms = ((ITextChannel)ctx.Channel);
-    //     await SendPerms(perms)
-    // }
-
+    
     [Cmd]
     [RequireContext(ContextType.Guild)]
     public async Task UserId([Leftover] IGuildUser? target = null)
@@ -337,31 +327,33 @@ public partial class Utility : EllieModule
         if (string.IsNullOrWhiteSpace(ownerIds))
             ownerIds = "-";
 
+        var eb = _sender.CreateEmbed()
+                        .WithOkColor()
+                        .WithAuthor($"EllieBot v{StatsService.BotVersion}",
+                            "https://cdn.elliebot.net/Ellie.png",
+                            "https://docs.elliebot.net/")
+                        .AddField(GetText(strs.author), _stats.Author, true)
+                        .AddField(GetText(strs.botid), _client.CurrentUser.Id.ToString(), true)
+                        .AddField(GetText(strs.shard),
+                            $"#{_client.ShardId} / {_creds.TotalShards}",
+                            true)
+                        .AddField(GetText(strs.commands_ran), _stats.CommandsRan.ToString(), true)
+                        .AddField(GetText(strs.messages),
+                            $"{_stats.MessageCounter} ({_stats.MessagesPerSecond:F2}/sec)",
+                            true)
+                        .AddField(GetText(strs.memory),
+                            FormattableString.Invariant($"{_stats.GetPrivateMemoryMegabytes():F2} MB"),
+                            true)
+                        .AddField(GetText(strs.owner_ids), ownerIds, true)
+                        .AddField(GetText(strs.uptime), _stats.GetUptimeString("\n"), true)
+                        .AddField(GetText(strs.presence),
+                            GetText(strs.presence_txt(_coord.GetGuildCount(),
+                                _stats.TextChannels,
+                                _stats.VoiceChannels)),
+                            true);
+
         await Response()
-              .Embed(_sender.CreateEmbed()
-                            .WithOkColor()
-                            .WithAuthor($"EllieBot v{StatsService.BotVersion}",
-                                "https://cdn.elliebot.net/Ellie.png",
-                                "https://docs.elliebot.net/")
-                            .AddField(GetText(strs.author), _stats.Author, true)
-                            .AddField(GetText(strs.botid), _client.CurrentUser.Id.ToString(), true)
-                            .AddField(GetText(strs.shard),
-                                $"#{_client.ShardId} / {_creds.TotalShards}",
-                                true)
-                            .AddField(GetText(strs.commands_ran), _stats.CommandsRan.ToString(), true)
-                            .AddField(GetText(strs.messages),
-                                $"{_stats.MessageCounter} ({_stats.MessagesPerSecond:F2}/sec)",
-                                true)
-                            .AddField(GetText(strs.memory),
-                                FormattableString.Invariant($"{_stats.GetPrivateMemoryMegabytes():F2} MB"),
-                                true)
-                            .AddField(GetText(strs.owner_ids), ownerIds, true)
-                            .AddField(GetText(strs.uptime), _stats.GetUptimeString("\n"), true)
-                            .AddField(GetText(strs.presence),
-                                GetText(strs.presence_txt(_coord.GetGuildCount(),
-                                    _stats.TextChannels,
-                                    _stats.VoiceChannels)),
-                                true))
+              .Embed(eb)
               .SendAsync();
     }