src/EllieBot/Modules/Help/Help.cs

@@ -509,7 +509,6 @@ public sealed partial class Help : EllieModule<HelpService>
 
         // send the indented file to chat
         await using var rDataStream = new MemoryStream(Encoding.ASCII.GetBytes(readableData));
-        await File.WriteAllTextAsync("data/commandlist.json", readableData);
         await ctx.Channel.SendFileAsync(rDataStream, "cmds.json", GetText(strs.commandlist_regen));
     }
 

src/EllieBot/Modules/Searches/Searches.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using Microsoft.Extensions.Caching.Memory;
 using EllieBot.Modules.Searches.Common;
 using EllieBot.Modules.Searches.Services;
@@ -113,7 +114,7 @@ public partial class Searches : EllieModule<SearchesService>
     }
 
     [Cmd]
-    public async Task Movie([Leftover] string query)
+    public async Task Movie([Leftover] string query = null)
     {
         if (!await ValidateQuery(query))
             return;
@@ -165,7 +166,7 @@ public partial class Searches : EllieModule<SearchesService>
     }
 
     [Cmd]
-    public async Task Lmgtfy([Leftover] string smh)
+    public async Task Lmgtfy([Leftover] string smh = null)
     {
         if (!await ValidateQuery(smh))
             return;
@@ -197,7 +198,6 @@ public partial class Searches : EllieModule<SearchesService>
               .SendAsync();
     }
 
-
     [Cmd]
     public async Task MagicTheGathering([Leftover] string search)
     {
@@ -255,23 +255,21 @@ public partial class Searches : EllieModule<SearchesService>
     }
 
     [Cmd]
-    public async Task UrbanDict([Leftover] string query)
+    public async Task UrbanDict([Leftover] string query = null)
     {
         if (!await ValidateQuery(query))
             return;
 
         await ctx.Channel.TriggerTypingAsync();
-        using var http = _httpFactory.CreateClient();
-        var res = await http.GetStringAsync($"https://api.urbandictionary.com/v0/define?"
-                                            + $"term={Uri.EscapeDataString(query)}");
-        var allItems = JsonConvert.DeserializeObject<UrbanResponse>(res)?.List;
-
-        if (allItems is null or { Length: 0 })
+        using (var http = _httpFactory.CreateClient())
+        {
+            var res = await http.GetStringAsync(
+                $"https://api.urbandictionary.com/v0/define?term={Uri.EscapeDataString(query)}");
+            try
+            {
+                var allItems = JsonConvert.DeserializeObject<UrbanResponse>(res).List;
+                if (allItems.Any())
                 {
-            await Response().Error(strs.ud_error).SendAsync();
-            return;
-        }
-
                     await Response()
                           .Paginated()
                           .Items(allItems)
@@ -287,6 +285,15 @@ public partial class Searches : EllieModule<SearchesService>
                                             .WithDescription(item.Definition);
                           })
                           .SendAsync();
+                    return;
+                }
+            }
+            catch
+            {
+            }
+        }
+
+        await Response().Error(strs.ud_error).SendAsync();
     }
 
     [Cmd]
@@ -343,7 +350,7 @@ public partial class Searches : EllieModule<SearchesService>
     [Cmd]
     public async Task Wiki([Leftover] string query)
     {
-        query = query.Trim();
+        query = query?.Trim();
 
         if (!await ValidateQuery(query))
             return;
@@ -385,17 +392,16 @@ public partial class Searches : EllieModule<SearchesService>
         for (var i = 0; i < colorObjects.Length; i++)
         {
             var x = i * 50;
-            var j = i;
-            img.Mutate(m => m.FillPolygon(colorObjects[j], new(x, 0), new(x + 50, 0), new(x + 50, 50), new(x, 50)));
+            img.Mutate(m => m.FillPolygon(colorObjects[i], new(x, 0), new(x + 50, 0), new(x + 50, 50), new(x, 50)));
         }
 
-        await using var ms = await img.ToStreamAsync();
+        await using var ms = img.ToStream();
         await ctx.Channel.SendFileAsync(ms, "colors.png");
     }
 
     [Cmd]
     [RequireContext(ContextType.Guild)]
-    public async Task Avatar([Leftover] IGuildUser? usr = null)
+    public async Task Avatar([Leftover] IGuildUser usr = null)
     {
         usr ??= (IGuildUser)ctx.User;
 

src/EllieBot/data/strings/commands/commands.en-US.yml

@@ -63,8 +63,10 @@ greet:
 greetmsg:
   desc: |-
     Sets a new join announcement message which will be shown in the current channel.
+    Write `%user.mention%` if you want to mention the new member.   
+    Full list of placeholders can be found here <https://docs.elliebot.net/ellie/features/placeholders/>
     Using this command with no message will show the current greet message.  
-    Supports [placeholders](https://docs.elliebot.net/ellie/features/placeholders/) and [embeds](https://eb.elliebot.net/)
+    You can use embed json from <https://eb.elliebot.net/> instead of regular text, if you want the message to be embedded.
   ex:
     - Welcome, %user.mention%.
   params:
@@ -79,8 +81,10 @@ bye:
 byemsg:
   desc: |-
     Sets a new leave announcement message which will be shown in the current channel. 
+    Type `%user.name%` to show the name of the user who left. 
+    Full list of placeholders can be found here <https://docs.elliebot.net/ellie/features/placeholders/>  
     Using this command with no message will show the current bye message. 
-    Supports [placeholders](https://docs.elliebot.net/ellie/features/placeholders/) and [embeds](https://eb.elliebot.net/)
+    You can use embed json from <https://eb.elliebot.net/> instead of regular text, if you want the message to be embedded.
   ex:
     - '%user.name% has left.'
   params:
@@ -109,9 +113,7 @@ greettest:
     - user:
         desc: "The user to impersonate when sending the greeting, defaulting to yourself if not specified."
 boosttest:
-  desc: |-
-    Sends the boost message in the current channel as if you just boosted the server.
-    You can optionally specify a different user.
+  desc: Sends the boost message in the current channel as if you just boosted the server. You can optionally specify a different user.
   ex:
     - ''
     - '@SomeoneElse'
@@ -143,8 +145,10 @@ boost:
 boostmsg:
   desc: |-
     Sets a new boost announcement message which will be shown in the current channel. 
+    Type `%user.mention%` if you want to mention the booster.
+    Full list of placeholders can be found here <https://docs.elliebot.net/ellie/features/placeholders/>
     Using this command with no message will show the current boost message. 
-    Supports [placeholders](https://docs.elliebot.net/ellie/features/placeholders/) and [embeds](https://eb.elliebot.net/)
+    You can use embed json from <https://eb.elliebot.net/> instead of regular text, if you want the message to be embedded.
   ex:
     - '%user.mention% has boosted the server!!!'
   params:
@@ -3079,7 +3083,7 @@ banmessage:
     - '{{ "description": "%ban.user% you have been banned from %server.name% by %ban.mod%" }}'
   params:
     - message:
-        desc: "The custom message to be displayed when a user is banned from the server."
+        desc: "The custom message to be displayed when a user is banned from the server, allowing for placeholders to be replaced with relevant information."
 banmessagetest:
   desc: If ban message is not disabled, bot will send you the message as if you were banned by yourself. Used for testing the ban message.
   ex: