Split if statement for more clarity

This commit is contained in:
Toastie 2024-12-26 18:01:10 +13:00
parent 3a94de9f23
commit c34a396c78
Signed by: toastie_t0ast
GPG key ID: 27F3B6855AFD40A4

View file

@ -76,9 +76,15 @@ internal static class EventHandler
return; return;
} }
// Sends a DM to the assigned staff member if at least a day has gone by since the last message and the user sending the message isn't staff // Ignore staff messages
if (Database.IsStaff(e.Author.Id))
{
return;
}
// Sends a DM to the assigned staff member if at least a day has gone by since the last message
IReadOnlyList<DiscordMessage> messages = await e.Channel.GetMessagesAsync(2); IReadOnlyList<DiscordMessage> messages = await e.Channel.GetMessagesAsync(2);
if (messages.Count > 1 && messages[1].Timestamp < DateTimeOffset.UtcNow.AddDays(Config.ticketUpdatedNotificationDelay * -1) && !Database.IsStaff(e.Author.Id)) if (messages.Count > 1 && messages[1].Timestamp < DateTimeOffset.UtcNow.AddDays(Config.ticketUpdatedNotificationDelay * -1))
{ {
try try
{ {
@ -99,17 +105,17 @@ internal static class EventHandler
switch (e.Exception) switch (e.Exception)
{ {
case SlashExecutionChecksFailedException checksFailedException: case SlashExecutionChecksFailedException checksFailedException:
{
foreach (SlashCheckBaseAttribute attr in checksFailedException.FailedChecks)
{ {
await e.Context.Channel.SendMessageAsync(new DiscordEmbedBuilder foreach (SlashCheckBaseAttribute attr in checksFailedException.FailedChecks)
{ {
Color = DiscordColor.Red, await e.Context.Channel.SendMessageAsync(new DiscordEmbedBuilder
Description = ParseFailedCheck(attr) {
}); Color = DiscordColor.Red,
Description = ParseFailedCheck(attr)
});
}
return;
} }
return;
}
case BadRequestException ex: case BadRequestException ex:
Logger.Error("Command exception occured:\n" + e.Exception); Logger.Error("Command exception occured:\n" + e.Exception);
@ -117,15 +123,15 @@ internal static class EventHandler
return; return;
default: default:
{
Logger.Error("Exception occured: " + e.Exception.GetType() + ": " + e.Exception);
await e.Context.Channel.SendMessageAsync(new DiscordEmbedBuilder
{ {
Color = DiscordColor.Red, Logger.Error("Exception occured: " + e.Exception.GetType() + ": " + e.Exception);
Description = "Internal error occured, please report this to the developer." await e.Context.Channel.SendMessageAsync(new DiscordEmbedBuilder
}); {
return; Color = DiscordColor.Red,
} Description = "Internal error occured, please report this to the developer."
});
return;
}
} }
} }